DEBUG-3472 send snapshot and status events together #4360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 22033 Passed, 1476 Skipped, 5m 52.03s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4360 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 1347 1347
Lines 82388 82388
Branches 4193 4193
=======================================
Hits 80522 80522
Misses 1866 1866 ☔ View full report in Codecov by Sentry. |
sarahchen6
approved these changes
Feb 10, 2025
Member
Author
|
The return value is whether any work was done, which requires |
p-datadog
pushed a commit
that referenced
this pull request
Feb 10, 2025
* di-worker-2: DEBUG-3457 start DI probe notifier worker on every event submission DEBUG-3472 send snapshot and status events together (#4360) Serialize span events via a dedicated field (#4279) Keep everything to sucker_punch test file. Remove unnecessary sucker_punch mutexes. Create separate method to get spans_count. Separate out spans' call to fetch_spans. Isolate sucker_punch fetch_spans calls. Add mutex to tracer_helpers. Run flaky test over and over and over...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes probe notifier worker to send both status and snapshot events in each iteration
Motivation:
When a probe executes for the first time, it emits a status event (that it is emitting) and the snapshot event (execution result). Currently these events are submitted to agent in different processing iterations, which upon reflection is not good - there was one action that caused both events to happen (probe execution), therefore both events should be submitted together.
There is also an issue in debugger-demo-ruby where the snapshot events are dropped between iterations for some reason. The root cause of this issue has not yet been identified but sending both events together works around the problem.
Change log entry
Yes: improve dynamic instrumentation event reporting
Additional Notes:
How to test the change?
I tested manually against debugger-demo-ruby. I don't think we have a CI configuration presently that can test this change.