Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

What does this PR do?

Mitigate JRuby 9.2 flakiness for bundle install

Change log entry

None.

@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Feb 10, 2025
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 10, 2025 15:53
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 10, 2025

Datadog Report

Branch report: tonycthsu/jruby-92-bundle-install-flake
Commit report: ffaeb2e
Test service: dd-trace-rb

✅ 0 Failed, 22031 Passed, 1476 Skipped, 7m 16.3s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (ba51201) to head (ffaeb2e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4361   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files        1347     1347           
  Lines       82390    82389    -1     
  Branches     4193     4193           
=======================================
  Hits        80528    80528           
+ Misses       1862     1861    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 10, 2025

Benchmarks

Benchmark execution time: 2025-02-10 20:00:21

Comparing candidate commit ffaeb2e in PR branch tonycthsu/jruby-92-bundle-install-flake with baseline commit ba51201 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/jruby-92-bundle-install-flake branch from 31f7d45 to ffaeb2e Compare February 10, 2025 19:36
@TonyCTHsu TonyCTHsu merged commit 9945a09 into master Feb 11, 2025
494 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/jruby-92-bundle-install-flake branch February 11, 2025 09:10
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/testing Involves testing processes (e.g. RSpec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants