Skip to content

[NO-TICKET] Fix flaky profiler object counting spec #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[NO-TICKET] Fix flaky profiler object counting spec #4362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion spec/datadog/profiling/collectors/cpu_and_wall_time_worker_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,6 +1345,10 @@
end

it "returns different numbers of allocations for different threads" do
# GC disabled for the same reason as "returns the exact number of allocations between two calls of the method"
# spec above.
GC.disable

# To get the exact expected number of allocations, we run this once before so that Ruby can create and cache all
# it needs to
new_object = proc { Object.new }
Expand Down Expand Up @@ -1374,8 +1378,10 @@
# This test checks that even though we observed 100 allocations in a background thread t1, the counters for
# the current thread were not affected by this change

expect(after_t1 - before_t1).to be 100
expect(after_t1 - before_t1).to be >= 100
expect(after_allocations - before_allocations).to be < 10
ensure
GC.enable
end

context "when allocation profiling is enabled but allocation counting is disabled" do
Expand Down
Loading