Remove loading psych gem early to fix cucumber spec
#4381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
changed the title
psych gem early to fix cucumber spec
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4381 +/- ##
==========================================
- Coverage 97.66% 97.66% -0.01%
==========================================
Files 1351 1351
Lines 82697 82697
Branches 4198 4198
==========================================
- Hits 80766 80764 -2
- Misses 1931 1933 +2 ☔ View full report in Codecov by Sentry. |
y9v
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cucumber release 9.2.1 that break our CircleCI Ruby 3.3 tests
https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/19242/workflows/95bce82e-302e-463f-96f2-eb8fbbfe8e30
psychfirst to mitigate the failure (This solves the broken spec but not sure if this is inviting problems from 3.0 - 3.2 )Change log entry
None