Skip to content

DEBUG-3498 Add exception information to the InternalErrorResponse stringification #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

DEBUG-3498 Add exception information to the InternalErrorResponse stringification #4383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/datadog/core/transport/response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ def internal_error?
true
end

def to_s
"#{super}, error_type:#{error.class} error:#{error}"
end

def inspect
"#{super}, error_type:#{error.class} error:#{error}"
end
Expand Down
6 changes: 6 additions & 0 deletions spec/datadog/core/transport/response_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,10 @@

it { is_expected.to be true }
end

describe '#to_s' do
it 'includes the causing exception' do
expect(response.to_s).to match(/StandardError/)
end
end
end
Loading