Skip to content

Conversation

@sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Feb 13, 2025

What does this PR do?
testing things with telemetry specs...

Motivation:

Change log entry
None.

Additional Notes:

How to test the change?

@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Feb 13, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 13, 2025

Datadog Report

Branch report: sarahchen6/unskip-telemetry-spec
Commit report: 3795754
Test service: dd-trace-rb

✅ 0 Failed, 20401 Passed, 1371 Skipped, 3m 22.11s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-19 22:34:28

Comparing candidate commit 3795754 in PR branch sarahchen6/unskip-telemetry-spec with baseline commit 30f6e21 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@sarahchen6 sarahchen6 force-pushed the sarahchen6/unskip-telemetry-spec branch 3 times, most recently from f147fb1 to 8224f7b Compare February 18, 2025 16:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.71%. Comparing base (c6d1822) to head (6017b45).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
spec/datadog/core/telemetry/worker_spec.rb 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4384      +/-   ##
==========================================
+ Coverage   97.70%   97.71%   +0.01%     
==========================================
  Files        1361     1361              
  Lines       83239    83243       +4     
  Branches     4226     4227       +1     
==========================================
+ Hits        81329    81344      +15     
+ Misses       1910     1899      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarahchen6 sarahchen6 force-pushed the sarahchen6/unskip-telemetry-spec branch from 2ce1b5d to c2b2ced Compare February 19, 2025 18:12
@sarahchen6 sarahchen6 force-pushed the sarahchen6/unskip-telemetry-spec branch from c2b2ced to 40b76c1 Compare February 19, 2025 19:18
@sarahchen6 sarahchen6 force-pushed the sarahchen6/unskip-telemetry-spec branch from 8b3ce26 to 70683e5 Compare February 19, 2025 21:10
@sarahchen6 sarahchen6 force-pushed the sarahchen6/unskip-telemetry-spec branch from 70683e5 to b2172f4 Compare February 19, 2025 21:23
@sarahchen6
Copy link
Contributor Author

Leaving these telemetry specs skipped for now :(

@sarahchen6 sarahchen6 closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/testing Involves testing processes (e.g. RSpec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants