Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Feb 13, 2025

What does this PR do?

Move pimpmychangelog to dev group

Motivation:

I want to see https://github.com/DataDog/dd-trace-rb/actions/workflows/cache-cleanup.yml job cleanup cache after this PR merged, because this branch changes the lockfile and dependencies

Change log entry
None

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Feb 13, 2025
@github-actions
Copy link

github-actions bot commented Feb 13, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-13 21:07:54 UTC

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/move-pimpmychangelog branch from 0b5ed79 to 6c29b13 Compare February 13, 2025 20:48
@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 13, 2025 21:07
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 13, 2025 21:07
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 21:18:57

Comparing candidate commit 45c4291 in PR branch tonycthsu/move-pimpmychangelog with baseline commit 8b8a31d in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-2980.573op/s; -2902.514op/s] or [-9.023%; -8.787%]

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-8286.436op/s; -7910.471op/s] or [-7.005%; -6.687%]

@TonyCTHsu TonyCTHsu enabled auto-merge February 13, 2025 21:12
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: tonycthsu/move-pimpmychangelog
Commit report: 45c4291
Test service: dd-trace-rb

✅ 0 Failed, 20098 Passed, 1364 Skipped, 3m 13.45s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (8b8a31d) to head (45c4291).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4385   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files        1352     1352           
  Lines       82735    82734    -1     
  Branches     4200     4200           
=======================================
  Hits        80825    80825           
+ Misses       1910     1909    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu merged commit eac4961 into master Feb 13, 2025
293 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/move-pimpmychangelog branch February 13, 2025 21:20
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/tooling Involves tools (e.g. Rubocop, CodeCov)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants