Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Feb 13, 2025

Motivation:

From this previous run for cleaning cache: https://github.com/DataDog/dd-trace-rb/actions/runs/13317290722

I learn that:

  1. The cache clean summary is not accurate with the status
  2. The cache clean does not fetch all the caches associate with the branch because the trigger event is PR closed.

What does this PR do?

  1. Remove status and createdAt field from the summary since they are less useful.
  2. Since cache size is limited (10Gb), modify jobs what are using caches to be triggered only with PR context instead of just branch pushes.

Change log entry
None

@TonyCTHsu TonyCTHsu added the dev/github Github repository maintenance and automation label Feb 13, 2025
@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 13, 2025 22:12
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 13, 2025 22:12
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: tonycthsu/improve-cache-clean-summary
Commit report: 55c03ab
Test service: dd-trace-rb

✅ 0 Failed, 20103 Passed, 1360 Skipped, 3m 15.73s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (eac4961) to head (55c03ab).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4386   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files        1352     1352           
  Lines       82735    82734    -1     
  Branches     4200     4200           
=======================================
+ Hits        80824    80825    +1     
+ Misses       1911     1909    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 22:18:56

Comparing candidate commit 55c03ab in PR branch tonycthsu/improve-cache-clean-summary with baseline commit eac4961 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu merged commit 4e27ecd into master Feb 13, 2025
494 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/improve-cache-clean-summary branch February 13, 2025 22:20
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/github Github repository maintenance and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants