DEBUG-3535 DRY transport Instance and Spec classes #4419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #4413, this PR moves the common contents of Transport::HTTP::API::Instance and Transport::HTTP::API::Spec classes (which is the one that was typed up in the respective files) to core.
The classes were subsequently augmented with per-component modules. I moved the common code to a base class such that there are still per-component Instance and Spec classes, except now the per-component classes derive from the base class and include the per-component modules.
Motivation:
Implementation of UDS transport for DI
Change log entry
None
Additional Notes:
The Client class is the last remaining duplicated one, it is out of scope for this PR.
How to test the change?
Existing unit tests