Skip to content

Conversation

@p-datadog
Copy link
Member

@p-datadog p-datadog commented Feb 21, 2025

What does this PR do?

Follow-up to #4413, this PR moves the common contents of Transport::HTTP::API::Instance and Transport::HTTP::API::Spec classes (which is the one that was typed up in the respective files) to core.

The classes were subsequently augmented with per-component modules. I moved the common code to a base class such that there are still per-component Instance and Spec classes, except now the per-component classes derive from the base class and include the per-component modules.

Motivation:

Implementation of UDS transport for DI

Change log entry
None

Additional Notes:

The Client class is the last remaining duplicated one, it is out of scope for this PR.

How to test the change?
Existing unit tests

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Feb 21, 2025
@github-actions
Copy link

github-actions bot commented Feb 21, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-21 06:18:47 UTC

@p-datadog p-datadog marked this pull request as ready for review February 21, 2025 06:23
@p-datadog p-datadog requested review from a team as code owners February 21, 2025 06:23
@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2025

Benchmarks

Benchmark execution time: 2025-02-21 06:46:29

Comparing candidate commit ff8f25b in PR branch di-uds with baseline commit 917747b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (917747b) to head (ff8f25b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4419      +/-   ##
==========================================
- Coverage   97.73%   97.71%   -0.03%     
==========================================
  Files        1365     1363       -2     
  Lines       83337    83309      -28     
  Branches     4219     4217       -2     
==========================================
- Hits        81447    81402      -45     
- Misses       1890     1907      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: di-uds
Commit report: ff8f25b
Test service: dd-trace-rb

✅ 0 Failed, 20607 Passed, 1371 Skipped, 3m 17.57s Total Time

@p-datadog p-datadog added this to the 2.11.0 milestone Feb 21, 2025
@p-datadog p-datadog merged commit 5c5ac39 into master Feb 21, 2025
499 checks passed
@p-datadog p-datadog deleted the di-uds branch February 21, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants