[PROF-11151] Fix test-memory-leaks flaky behavior #4434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR will hopefully fix almost [all of the the flakiness](https://github.com/DataDog/dd-trace-rb/pulls?q=is%3Apr+asan) we've seen from the test-memory-leaks GitHub workflow. The previous "asan" builds we were using were built from ruby-head, which means that any instability or early breakage in ruby-head would make test-memory-leaks fail. To fix this, I've worked with upstream to create these 3.4-asan builds: these are Ruby builds that are built **from the latest 3.4 stable Ruby** with asan. Thus any breakages we see in them, should also exist in regular 3.4 builds. **Motivation:** With this change, the test-memory-leaks workflow becomes a lot more valuable, since it's now never expected to fail. Thus, any failures we see in it are worth investigating. **Additional Notes:** For context, asan (or ASan) is the "AddressSanitizer" tool, see https://github.com/google/sanitizers/wiki/AddressSanitizer for more details. **How to test the change?** Validate that the updated workflow is running on ruby-3.4.2 and that it still has the diagnostic output from asan.
github-actions
bot
added
the
dev/github
ivoanjo
added
dev/testing
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 20610 Passed, 1379 Skipped, 3m 17.28s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4434 +/- ##
==========================================
- Coverage 97.73% 97.71% -0.02%
==========================================
Files 1368 1368
Lines 83438 83438
Branches 4220 4220
==========================================
- Hits 81549 81534 -15
- Misses 1889 1904 +15 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-02-25 09:59:03 Comparing candidate commit a652d62 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
TonyCTHsu
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will hopefully fix almost all of the the
flakiness we've seen from the test-memory-leaks GitHub workflow.
The previous "asan" builds we were using were built from ruby-head, which means that any instability or early breakage in ruby-head would make test-memory-leaks fail.
To fix this, I've worked with upstream to create these 3.4-asan builds: these are Ruby builds that are built from the latest 3.4 stable Ruby with asan. Thus any breakages we see in them, should also exist in regular 3.4 builds.
Motivation:
With this change, the test-memory-leaks workflow becomes a lot more valuable, since it's now never expected to fail.
Thus, any failures we see in it are worth investigating.
Change log entry
None.
Additional Notes:
For context, asan (or ASan) is the "AddressSanitizer" tool, see https://github.com/google/sanitizers/wiki/AddressSanitizer for more details.
How to test the change?
Validate that the updated workflow is running on ruby-3.4.2 and that it still has the diagnostic output from asan.