Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

This is a PR to update documentation for v2.12.0. Please merge (with a merge commit) when ready

TonyCTHsu and others added 30 commits February 23, 2025 00:17
…ntation

Add RestClient instrumentation for SSRF detection
**What does this PR do?**

This PR will hopefully fix almost [all of the the
flakiness](https://github.com/DataDog/dd-trace-rb/pulls?q=is%3Apr+asan)
we've seen from the test-memory-leaks GitHub workflow.

The previous "asan" builds we were using were built from ruby-head,
which means that any instability or early breakage in ruby-head would
make test-memory-leaks fail.

To fix this, I've worked with upstream to create these 3.4-asan builds:
these are Ruby builds that are built **from the latest 3.4 stable Ruby**
with asan. Thus any breakages we see in them, should also exist in
regular 3.4 builds.

**Motivation:**

With this change, the test-memory-leaks workflow becomes a lot more
valuable, since it's now never expected to fail.

Thus, any failures we see in it are worth investigating.

**Additional Notes:**

For context, asan (or ASan) is the "AddressSanitizer" tool, see
https://github.com/google/sanitizers/wiki/AddressSanitizer for more
details.

**How to test the change?**

Validate that the updated workflow is running on ruby-3.4.2 and that
it still has the diagnostic output from asan.
[PROF-11151] Fix test-memory-leaks flaky behavior
…endencies

[🤖] Update Latest Dependency
@github-actions
Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-02-27 14:56:37 UTC

@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations appsec Application Security monitoring product tracing labels Feb 27, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 27, 2025

Benchmarks

Benchmark execution time: 2025-02-27 15:18:54

Comparing candidate commit 7e57abb in PR branch update-document-v2.12.0 with baseline commit 2d817ff in branch release.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 27, 2025 16:23
@TonyCTHsu TonyCTHsu requested review from a team as code owners February 27, 2025 16:23
@TonyCTHsu TonyCTHsu merged commit 54efa06 into release Feb 27, 2025
676 of 678 checks passed
@TonyCTHsu TonyCTHsu deleted the update-document-v2.12.0 branch February 27, 2025 16:37
@github-actions github-actions bot added this to the 2.13.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants