Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

What does this PR do?

Remove CircleCI.

Change log entry

None.

@TonyCTHsu TonyCTHsu added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Feb 27, 2025
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/drop-circleci branch from f9499a2 to 64f9297 Compare February 27, 2025 16:17
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 27, 2025

Datadog Report

Branch report: tonycthsu/drop-circleci
Commit report: 3e3511b
Test service: dd-trace-rb

✅ 0 Failed, 20611 Passed, 1373 Skipped, 3m 14.35s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (a02f64a) to head (3e3511b).
Report is 830 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4444      +/-   ##
==========================================
- Coverage   97.70%   97.69%   -0.01%     
==========================================
  Files        1374     1374              
  Lines       83806    83807       +1     
  Branches     4249     4249              
==========================================
- Hits        81881    81874       -7     
- Misses       1925     1933       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lloeki lloeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-27 at 17 34 15

Approved, although a note that we have a persistent failure now; we may need to adjust a knob on the CircleCI side?

@brettlangdon
Copy link
Member

Screenshot 2025-02-27 at 17 34 15 Approved, although a note that we have a persistent failure now; we may need to adjust a knob on the CircleCI side?

As long as it isn't a required job, then should be ok ? the next run might be alright?

we probably cannot 100% disable CircleCI (in their UI) since if we have to backport changes to an older branch/release then it'll have the CircleCI config?

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/drop-circleci branch from 64f9297 to 3e3511b Compare February 27, 2025 16:41
@pr-commenter
Copy link

pr-commenter bot commented Feb 27, 2025

Benchmarks

Benchmark execution time: 2025-02-27 17:05:01

Comparing candidate commit 3e3511b in PR branch tonycthsu/drop-circleci with baseline commit a02f64a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu
Copy link
Contributor Author

Screenshot 2025-02-27 at 17 34 15 Approved, although a note that we have a persistent failure now; we may need to adjust a knob on the CircleCI side?

I removed the configured webhook to mitigate this.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 27, 2025 16:59
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 27, 2025 16:59
@TonyCTHsu TonyCTHsu merged commit 987b7a6 into master Feb 28, 2025
273 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/drop-circleci branch February 28, 2025 08:09
@github-actions github-actions bot added this to the 2.13.0 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/ci Involves CircleCI, GitHub Actions, or GitLab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants