Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Mar 4, 2025

What does this PR do?

Fix the failure from. https://github.com/DataDog/dd-trace-rb/actions/runs/13569050345

Change log entry
None.

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Mar 4, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: tonycthsu/fix-publish-action
Commit report: 4bf8b01
Test service: dd-trace-rb

✅ 0 Failed, 20608 Passed, 1373 Skipped, 3m 12.96s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (a574273) to head (4bf8b01).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4452      +/-   ##
==========================================
- Coverage   97.70%   97.69%   -0.02%     
==========================================
  Files        1374     1374              
  Lines       83807    83806       -1     
  Branches     4249     4249              
==========================================
- Hits        81882    81872      -10     
- Misses       1925     1934       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Mar 4, 2025

Benchmarks

Benchmark execution time: 2025-03-04 14:11:02

Comparing candidate commit 4bf8b01 in PR branch tonycthsu/fix-publish-action with baseline commit a574273 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiler - stack collector

  • 🟩 throughput [+159.376op/s; +160.932op/s] or [+5.863%; +5.920%]

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-6470.622op/s; -6156.698op/s] or [-5.504%; -5.237%]

@TonyCTHsu TonyCTHsu marked this pull request as ready for review March 4, 2025 21:35
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner March 4, 2025 21:35
@TonyCTHsu TonyCTHsu added this to the 2.13.0 milestone Mar 4, 2025
@TonyCTHsu TonyCTHsu merged commit 34bf118 into master Mar 4, 2025
481 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-publish-action branch March 4, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/github Github repository maintenance and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants