Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Mar 19, 2025

What does this PR do?
This PR adds Stack Trace reporting to the Datadog Agent in case of an AppSec event with generate_stack action.

Motivation:
We are not handling generate_stack action yet.

Change log entry
Yes. AppSec: Add stack trace reporting for security events.

Additional Notes:
None.

How to test the change?
CI and local testing with app-generator (SSRF or SQLi variants).

@y9v y9v self-assigned this Mar 19, 2025
@y9v y9v requested a review from a team as a code owner March 19, 2025 09:19
@github-actions github-actions bot added the appsec Application Security monitoring product label Mar 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (7d88b81) to head (bf5323c).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4526      +/-   ##
==========================================
+ Coverage   97.70%   97.74%   +0.04%     
==========================================
  Files        1381     1388       +7     
  Lines       83973    84487     +514     
  Branches     4251     4272      +21     
==========================================
+ Hits        82043    82579     +536     
+ Misses       1930     1908      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 19, 2025

Datadog Report

Branch report: appsec-stack-trace-reporting
Commit report: bf5323c
Test service: dd-trace-rb

✅ 0 Failed, 20677 Passed, 1374 Skipped, 3m 15.21s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2025

Benchmarks

Benchmark execution time: 2025-03-19 16:48:18

Comparing candidate commit bf5323c in PR branch appsec-stack-trace-reporting with baseline commit 7d88b81 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Contributor

@vpellan vpellan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that other than the env vars defaults, it's good to go !

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍🏼

I've left a few non-blocking suggestions

@y9v y9v force-pushed the appsec-stack-trace-reporting branch from 8e33c92 to 0d8e709 Compare March 19, 2025 15:59
@y9v y9v merged commit 97354cd into master Mar 20, 2025
461 checks passed
@y9v y9v deleted the appsec-stack-trace-reporting branch March 20, 2025 08:59
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 20, 2025
@vpellan vpellan mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants