-
Notifications
You must be signed in to change notification settings - Fork 398
Add Stack Trace reporting for AppSec actions #4526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4526 +/- ##
==========================================
+ Coverage 97.70% 97.74% +0.04%
==========================================
Files 1381 1388 +7
Lines 83973 84487 +514
Branches 4251 4272 +21
==========================================
+ Hits 82043 82579 +536
+ Misses 1930 1908 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20677 Passed, 1374 Skipped, 3m 15.21s Total Time |
BenchmarksBenchmark execution time: 2025-03-19 16:48:18 Comparing candidate commit bf5323c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
vpellan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that other than the env vars defaults, it's good to go !
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👍🏼
I've left a few non-blocking suggestions
spec/datadog/appsec/actions_handler/serializable_backtrace_spec.rb
Outdated
Show resolved
Hide resolved
spec/datadog/appsec/actions_handler/serializable_backtrace_spec.rb
Outdated
Show resolved
Hide resolved
8e33c92 to
0d8e709
Compare
What does this PR do?
This PR adds Stack Trace reporting to the Datadog Agent in case of an AppSec event with
generate_stackaction.Motivation:
We are not handling
generate_stackaction yet.Change log entry
Yes. AppSec: Add stack trace reporting for security events.
Additional Notes:
None.
How to test the change?
CI and local testing with app-generator (SSRF or SQLi variants).