Skip to content

Conversation

@p-datadog
Copy link
Member

Copy of #4499 but in a branch in this repo to run all of the workflows.

What does this PR do?

Added RBS for Datadog::Tracing.correlation.

Motivation:

I am developing a Rails application utilizing types with Steep/RBS.
Since the type definitions for the datadog gem were incomplete, I added the missing type definitions.

Additional Notes:

How to test the change?

No application code has been changed.
I have confirmed that steep check passes successfully.

euglena1215 and others added 6 commits March 27, 2025 16:04
I am developing a Rails application utilizing types with Steep/RBS.
Since the type definitions for the datadog gem were incomplete,
I added the missing type definitions.
@p-datadog p-datadog requested review from a team as code owners March 27, 2025 20:20
@p-datadog p-datadog marked this pull request as draft March 27, 2025 20:23
@github-actions
Copy link

👋 Hey @p-datadog, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-03-27 20:27:10 UTC

@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2025

Benchmarks

Benchmark execution time: 2025-03-27 20:40:51

Comparing candidate commit 641d1b9 in PR branch add-correlation-rbs with baseline commit c0a829b in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-2587.489op/s; -2511.315op/s] or [-8.096%; -7.858%]

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+4356.839op/s; +4468.945op/s] or [+12.924%; +13.256%]

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: add-correlation-rbs
Commit report: 641d1b9
Test service: dd-trace-rb

✅ 0 Failed, 20592 Passed, 1370 Skipped, 3m 24.07s Total Time

@p-datadog p-datadog closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants