Skip to content

Conversation

@marcotc
Copy link
Member

@marcotc marcotc commented Mar 27, 2025

The bus factor is too low for apm-idm-ruby today.
With only two members:

  • A PR from one of the two members HAS to be approved by the other; no replacement reviewer qualifies. If one member is away, the other cannot merge their work.
  • If both members are away, no PR touching tracing/contrib can be merged.

This PR changes the ownership of tracing/contrib files to tracing-ruby, which has four members and already owns tracing and opentelemetry. The members tracing-ruby are: both apm-idm-ruby members plus two other very smart and handsome Ruby engineers.

Change log entry
No

@marcotc marcotc self-assigned this Mar 27, 2025
@marcotc marcotc requested a review from a team as a code owner March 27, 2025 21:28
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Mar 27, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (afad677) to head (58da147).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4542   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files        1392     1392           
  Lines       84973    84972    -1     
  Branches     4285     4285           
=======================================
  Hits        83077    83077           
+ Misses       1896     1895    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: marcotc/tracing-owners
Commit report: 58da147
Test service: dd-trace-rb

✅ 0 Failed, 20785 Passed, 1373 Skipped, 3m 15.33s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2025

Benchmarks

Benchmark execution time: 2025-03-27 21:44:17

Comparing candidate commit 58da147 in PR branch marcotc/tracing-owners with baseline commit afad677 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@sarahchen6 sarahchen6 merged commit 679838e into master Mar 28, 2025
255 checks passed
@sarahchen6 sarahchen6 deleted the marcotc/tracing-owners branch March 28, 2025 13:23
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/github Github repository maintenance and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants