-
Notifications
You must be signed in to change notification settings - Fork 399
DEBUG-3700 Remove duplicated classes from Telemetry transport #4575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-04-10 17:30:19 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 20773 Passed, 1462 Skipped, 3m 46.65s Total Time |
BenchmarksBenchmark execution time: 2025-04-29 18:20:35 Comparing candidate commit 53466ae in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Trace Context
|
f69c8e1 to
b723f99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4575 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.02%
==========================================
Files 1415 1409 -6
Lines 86247 85968 -279
Branches 4359 4352 -7
==========================================
- Hits 84293 84010 -283
- Misses 1954 1958 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
datadog-ci-rb uses one of the removed clasess thusly: LoadError is not derived from StandardError and will escape the rescue above. I will put back the file with a dummy class definition. |
71db6d6 to
36e7844
Compare
36e7844 to
10fdb16
Compare
|
Correction for the changelog entry as 1.16.0 is the current version: Customers using datadog-ci-rb and webmock will need to update datadog-ci-rb to version 1.17.0 or later. |
|
I tested this branch together with fixes from DataDog/datadog-ci-rb#309 using Test Optimization integration tests: https://gitlab.ddbuild.io/DataDog/apm-reliability/test-environment/-/pipelines/63750300 |
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* master: Avoid method redefinition warning when replacing time providers (DataDog#4613) DEBUG-3700 Remove duplicated classes from Telemetry transport (DataDog#4575)

What does this PR do?
Removes duplicated Core classes from Telemetry transport code.
Motivation:
As part of getting telemetry working for dynamic instrumentation, telemetry needs to work with UDS which is what shopist uses. Currently Telemetry only supports HTTP. Using the Core transport code will bring UDS transport to Telemetry.
Change log entry
Yes: Improve telemetry transport. Customers using datadog-ci-rb and webmock will need to update datadog-ci-rb to version 1.17.0 or later.
Additional Notes:
This is the first PR of a series. the next one will add a Core-based transport. This PR should be quick to review and conceptually it is standalone.
How to test the change?
Existing unit tests
I also ran datadog-ci-rb 1.15.0 tests against this PR.