-
Notifications
You must be signed in to change notification settings - Fork 399
DEBUG-3700 agentless settings resolver #4590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-05-08 18:07:25 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 21239 Passed, 1373 Skipped, 3m 32.8s Total Time |
BenchmarksBenchmark execution time: 2025-05-08 18:26:53 Comparing candidate commit fa54149 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiling - hold / resume
|
4b08513 to
e5eba87
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4590 +/- ##
==========================================
- Coverage 97.76% 97.76% -0.01%
==========================================
Files 1412 1414 +2
Lines 86236 86410 +174
Branches 4348 4379 +31
==========================================
+ Hits 84312 84477 +165
- Misses 1924 1933 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ab5f384 to
43483bd
Compare
43483bd to
fa54149
Compare
What does this PR do?
Adds an agentless settings resolver, which performs the same function as the agent settings resolver to go from settings/Datadog configuration to agent settings, but for agentless operations (currently only telemetry).
Motivation:
Existing code (telemetry transport) did not have the agent settings resolution as an encapsulated concept. As a result, there was low test coverage for this code and for example the timeout was always fixed at 30 seconds.
With the upcoming PR that will change telemetry to use core transport code, telemetry will need to provide agent settings to the transport even in agentless mode. The agentless settings resolver that this PR adds provides the required bridge.
Change log entry
Yes: improve agentless mode telemetry configuration - it now respects timeout specified for the agent
Additional Notes:
This PR shares the
with_envhelper with #4588. I originally wrote it for this PR and cherry-picked it into 4588.How to test the change?
A bunch of tests/assertions are added with this PR.
This PR was also tested as part of the in-progress PR for UDS support (#4630).