Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Apr 25, 2025

Motivation:

It was slow and hard to debug.

What does this PR do?

  1. Improve the checks in a more performant way (scoped with Github Actions App ID)
  2. Enrich debug info with annotation
  3. Extract JS scripts

Change log entry
None.

@TonyCTHsu TonyCTHsu added do-not-merge/WIP Not ready for merge dev/github Github repository maintenance and automation github_actions Pull requests that update GitHub Actions code labels Apr 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (b9e1364) to head (449beea).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4606      +/-   ##
==========================================
- Coverage   97.74%   97.73%   -0.02%     
==========================================
  Files        1412     1412              
  Lines       86256    86255       -1     
  Branches     4354     4354              
==========================================
- Hits        84314    84300      -14     
- Misses       1942     1955      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Apr 25, 2025

Datadog Report

Branch report: tonycthsu/refine-quality-checks
Commit report: 449beea
Test service: dd-trace-rb

✅ 0 Failed, 21011 Passed, 1376 Skipped, 3m 32.21s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Apr 25, 2025

Benchmarks

Benchmark execution time: 2025-04-28 14:31:16

Comparing candidate commit 449beea in PR branch tonycthsu/refine-quality-checks with baseline commit b9e1364 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/refine-quality-checks branch from c52109d to c9fa698 Compare April 28, 2025 11:45
@TonyCTHsu TonyCTHsu removed the do-not-merge/WIP Not ready for merge label Apr 28, 2025
@TonyCTHsu TonyCTHsu changed the title WIP: Refine quality checks before publication Refine quality checks before publication Apr 28, 2025
@TonyCTHsu TonyCTHsu marked this pull request as ready for review April 28, 2025 12:26
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner April 28, 2025 12:26
@TonyCTHsu TonyCTHsu added this to the 2.16.0 milestone Apr 28, 2025
Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a description to the JS files saying what they do?

Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TonyCTHsu TonyCTHsu merged commit ae89815 into master Apr 29, 2025
442 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/refine-quality-checks branch April 29, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/github Github repository maintenance and automation github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants