Skip to content

Conversation

@p-datadog
Copy link
Member

What does this PR do?

DRY the code to set up a Webrick server listening on a unix domain socket

Motivation:

UDS testing for telemetry (in #4630) + DRY existing test code

Change log entry
None

Additional Notes:

How to test the change?
Existing CI

@p-datadog p-datadog requested review from a team as code owners May 12, 2025 13:36
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label May 12, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented May 12, 2025

Datadog Summary

❌ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

@p-datadog p-datadog force-pushed the uds-http-server-helper branch from a5476ae to bd8c730 Compare May 12, 2025 13:50
@pr-commenter
Copy link

pr-commenter bot commented May 12, 2025

Benchmarks

Benchmark execution time: 2025-05-12 14:14:12

Comparing candidate commit bd8c730 in PR branch uds-http-server-helper with baseline commit deadb14 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiling - hold / resume

  • 🟩 throughput [+89287.430op/s; +93050.113op/s] or [+5.457%; +5.687%]

scenario:tracing - Propagation - Trace Context

  • 🟥 throughput [-4055.314op/s; -3944.274op/s] or [-10.848%; -10.551%]

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.77%. Comparing base (deadb14) to head (7d91eb4).
Report is 534 commits behind head on master.

Files with missing lines Patch % Lines
spec/datadog/core/crashtracking/component_spec.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4636      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files        1415     1415              
  Lines       86568    86560       -8     
  Branches     4386     4386              
==========================================
- Hits        84644    84632      -12     
- Misses       1924     1928       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@p-datadog p-datadog changed the title UDS HTTP server helper for test suite DEBUG-3700 UDS HTTP server helper for test suite May 12, 2025
@p-datadog p-datadog merged commit 1f6a7c5 into master May 12, 2025
264 of 266 checks passed
@p-datadog p-datadog deleted the uds-http-server-helper branch May 12, 2025 17:33
@github-actions github-actions bot added this to the 2.16.0 milestone May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/testing Involves testing processes (e.g. RSpec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants