-
Notifications
You must be signed in to change notification settings - Fork 399
DEBUG-3700 Inject telemetry into metrics client #4641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-05-12 19:03:24 UTC |
Datadog Summary✅ Dependencies Test Optimization ReportBranch report: ✅ 0 Failed, 21254 Passed, 1377 Skipped, 3m 46.84s Total Time Was this helpful? Give us feedback! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4641 +/- ##
==========================================
- Coverage 97.77% 97.76% -0.01%
==========================================
Files 1419 1422 +3
Lines 86624 86703 +79
Branches 4397 4403 +6
==========================================
+ Hits 84697 84769 +72
- Misses 1927 1934 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-05-15 15:35:48 Comparing candidate commit e85c6b5 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:method instrumentation
|
Datadog ReportBranch report: ✅ 0 Failed, 21046 Passed, 1373 Skipped, 3m 44.83s Total Time |
2251148 to
2c47270
Compare
What does this PR do?
Injects telemetry into metrics client instead of retrieving it from the components tree.
Motivation:
References to the components tree currently create the tree if it does not exist by default (
allow_initializationoption tocomponents). This creation is problematic in the test suite (see #4619). Some components appear to rely on this automatic instantiation (profiling, possibly tracing), therefore removing it is non-trivial. In the meantime, metrics client can have telemetry injected into it to avoid the issue altogether (and remove what is effectively a global variable reference).Change log entry
None
Additional Notes:
How to test the change?
Existing CI