-
Notifications
You must be signed in to change notification settings - Fork 399
DEBUG-3573 Add integration test for telemetry app-heartbeat event payloads #4643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-05-13 23:14:56 UTC |
BenchmarksBenchmark execution time: 2025-05-14 14:20:42 Comparing candidate commit 2d65e46 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:profiling - gvl benchmark samples
scenario:tracing - Propagation - Trace Context
scenario:tracing - Tracing.log_correlation
|
834248a to
e68271e
Compare
26093fc to
51bf7a6
Compare
Datadog ReportBranch report: ✅ 0 Failed, 21239 Passed, 1462 Skipped, 3m 51.64s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4643 +/- ##
==========================================
- Coverage 97.77% 97.77% -0.01%
==========================================
Files 1418 1419 +1
Lines 86587 86624 +37
Branches 4396 4397 +1
==========================================
+ Hits 84662 84693 +31
- Misses 1925 1931 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes, but I do have concerns over mutating "run once" constant, I would love to see it as a stub, over the mutation
What does this PR do?
Adds an integration test for AppHeartbeat telemetry event with payload assertions
Motivation:
Debugging why telemetry is not working properly for dynamic instrumentation - the UI requires telemetry heartbeats to show correct information but these are not seen by the backend
Change log entry
None
Additional Notes:
This PR duplicates the
mark_telemetry_startedhelper from #4640How to test the change?
PR is tests only