Skip to content

Conversation

@p-datadog
Copy link
Member

@p-datadog p-datadog commented May 12, 2025

What does this PR do?

Adds an integration test for AppHeartbeat telemetry event with payload assertions

Motivation:
Debugging why telemetry is not working properly for dynamic instrumentation - the UI requires telemetry heartbeats to show correct information but these are not seen by the backend

Change log entry
None

Additional Notes:

This PR duplicates the mark_telemetry_started helper from #4640

How to test the change?
PR is tests only

@github-actions
Copy link

github-actions bot commented May 12, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-05-13 23:14:56 UTC

@github-actions github-actions bot added the core Involves Datadog core libraries label May 12, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 12, 2025

Benchmarks

Benchmark execution time: 2025-05-14 14:20:42

Comparing candidate commit 2d65e46 in PR branch telemetry-heartbeat-test with baseline commit f927b70 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:profiling - gvl benchmark samples

  • 🟥 throughput [-601.227op/s; -592.728op/s] or [-5.212%; -5.139%]

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+3558.068op/s; +3666.560op/s] or [+10.578%; +10.900%]

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-8373.041op/s; -8107.294op/s] or [-7.695%; -7.451%]

@p-datadog p-datadog force-pushed the telemetry-heartbeat-test branch from 834248a to e68271e Compare May 13, 2025 14:35
@github-actions github-actions bot added the appsec Application Security monitoring product label May 13, 2025
@p-datadog p-datadog force-pushed the telemetry-heartbeat-test branch from 26093fc to 51bf7a6 Compare May 13, 2025 22:03
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label May 13, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented May 13, 2025

Datadog Report

Branch report: telemetry-heartbeat-test
Commit report: 2d65e46
Test service: dd-trace-rb

✅ 0 Failed, 21239 Passed, 1462 Skipped, 3m 51.64s Total Time

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.77%. Comparing base (f927b70) to head (2d65e46).
Report is 328 commits behind head on master.

Files with missing lines Patch % Lines
spec/support/telemetry_helpers.rb 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4643      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files        1418     1419       +1     
  Lines       86587    86624      +37     
  Branches     4396     4397       +1     
==========================================
+ Hits        84662    84693      +31     
- Misses       1925     1931       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@p-datadog p-datadog changed the title Add integration test for telemetry app-heartbeat event payloads DEBUG-3573 Add integration test for telemetry app-heartbeat event payloads May 13, 2025
@p-datadog p-datadog marked this pull request as ready for review May 13, 2025 23:14
@p-datadog p-datadog requested a review from a team as a code owner May 13, 2025 23:14
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, but I do have concerns over mutating "run once" constant, I would love to see it as a stub, over the mutation

@p-datadog p-datadog merged commit 1764000 into master May 14, 2025
254 checks passed
@p-datadog p-datadog deleted the telemetry-heartbeat-test branch May 14, 2025 14:33
@github-actions github-actions bot added this to the 2.16.0 milestone May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product core Involves Datadog core libraries dev/testing Involves testing processes (e.g. RSpec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants