Skip to content

Conversation

@Strech
Copy link
Member

@Strech Strech commented May 13, 2025

What does this PR do?

Adds handling of business logic events to be able to finish fingerprinting feature.

Motivation:

The last bits of fingerprinting is to act on business logic events that produced during sign in via auto-instrumentation or SDK.

Change log entry

Yes. AppSec: Add session tracking and fingerprinting support to devise and rails contribs.

Additional Notes:

I would like to restructure integration tests to better separate specifically contrib tests from general logic tests. Hence you would see test in the rack contrib (for now)

Second - we have an issue in libddwaf-rb which converts provided nil values into empty strings. Another option is to give a value invalid which doesn't make much sense, but it is what it is.

This is what's new in system-tests

Screenshot 2025-05-13 at 11 59 46

How to test the change?

CI + ST

@github-actions github-actions bot added the appsec Application Security monitoring product label May 13, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented May 13, 2025

Datadog Summary

❌ Code Quality    ✅ Code Security    ✅ Dependencies

Test Optimization Report

Branch report: appsec-57237-add-business-events-handling
Commit report: 59616ae
Test service: dd-trace-rb

✅ 0 Failed, 21256 Passed, 1373 Skipped, 3m 57.94s Total Time


Was this helpful? Give us feedback!

@Strech Strech marked this pull request as ready for review May 13, 2025 09:58
@Strech Strech requested review from a team as code owners May 13, 2025 09:58
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.77%. Comparing base (1edbedf) to head (28cc8a2).

Files with missing lines Patch % Lines
lib/datadog/appsec/monitor/gateway/watcher.rb 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4644      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files        1415     1416       +1     
  Lines       86561    86631      +70     
  Branches     4386     4391       +5     
==========================================
+ Hits        84633    84701      +68     
- Misses       1928     1930       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Strech Strech force-pushed the appsec-57237-add-business-events-handling branch 2 times, most recently from aa9cea3 to 06ae6d7 Compare May 13, 2025 13:13
* Update system-tests target
@Strech Strech force-pushed the appsec-57237-add-business-events-handling branch from 06ae6d7 to baaef72 Compare May 13, 2025 13:16
@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmark execution time: 2025-05-13 13:39:58

Comparing candidate commit baaef72 in PR branch appsec-57237-add-business-events-handling with baseline commit 15a6b5f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@Strech Strech merged commit 20efc6c into master May 13, 2025
443 checks passed
@Strech Strech deleted the appsec-57237-add-business-events-handling branch May 13, 2025 13:55
@github-actions github-actions bot added this to the 2.16.0 milestone May 13, 2025
@Strech Strech mentioned this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants