Skip to content

Conversation

@p-datadog
Copy link
Member

@p-datadog p-datadog commented May 13, 2025

What does this PR do?

Implements the debug flag for telemetry as described in troubleshooting documentation

Motivation:
Trying to get telemetry work for dynamic instrumentation

Change log entry
None

Additional Notes:

How to test the change?
Integration test is added.
I also followed the debugging instructions and verified the telemetry is being received by the backend and is claimed to have valid payloads.

@github-actions github-actions bot added the core Involves Datadog core libraries label May 13, 2025
@github-actions
Copy link

github-actions bot commented May 13, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-05-14 14:43:45 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented May 13, 2025

Datadog Report

Branch report: telemetry-debug
Commit report: f4ce99c
Test service: dd-trace-rb

✅ 0 Failed, 21245 Passed, 1373 Skipped, 3m 45.32s Total Time

@p-datadog p-datadog changed the title Implement debug flag for telemetry DEBUG-3573 Implement debug flag for telemetry May 13, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025

Benchmarks

Benchmark execution time: 2025-05-15 13:32:31

Comparing candidate commit f4ce99c in PR branch telemetry-debug with baseline commit 1764000 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@p-datadog p-datadog marked this pull request as ready for review May 14, 2025 14:43
@p-datadog p-datadog requested a review from a team as a code owner May 14, 2025 14:43
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (1764000) to head (f4ce99c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4648   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1419     1421    +2     
  Lines       86623    86696   +73     
  Branches     4397     4404    +7     
=======================================
+ Hits        84693    84767   +74     
+ Misses       1930     1929    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@p-datadog p-datadog added this to the 2.16.0 milestone May 14, 2025
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

The only comment I have, let's make debug as the last option, because it's less important as all other

@p-datadog
Copy link
Member Author

Moved to the end.

@p-datadog p-datadog merged commit d01791a into master May 15, 2025
820 of 823 checks passed
@p-datadog p-datadog deleted the telemetry-debug branch May 15, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants