-
Notifications
You must be signed in to change notification settings - Fork 398
Add Ruby 3.5 preview support #4924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9d0a632
Add Ruby 3.5
sarahchen6 adbf8ce
Skip tests
sarahchen6 ef9d42f
Address review comments
sarahchen6 b2ec734
Add comment to address Ruby 3.5 TODOs
sarahchen6 83a7fda
Unskip shoryuken test
sarahchen6 d1a8766
Permanently skip ratio_in_ygit check
sarahchen6 acec15a
Address review comments
sarahchen6 bb5f7e4
Add mongo tests back
sarahchen6 61482ce
Merge bb5f7e43e5d7ffbe68af78ad05e9cb6d1c02c090 into c0f2229c832db9383…
sarahchen6 491912a
[🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/r…
dd-apm-ecosystems-autobot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ jobs: | |
| - '3.2' | ||
| - '3.3' | ||
| - '3.4' | ||
| - '3.5' | ||
| # ADD NEW RUBIES HERE | ||
| rubyopt: | ||
| - '--yjit' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| FROM ghcr.io/datadog/images-rb/engines/ruby:3.5-centos-gcc | ||
sarahchen6 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,196 @@ | ||
| appraise 'rails7' do | ||
| gem 'rails', '~> 7.0.0' | ||
| end | ||
|
|
||
| appraise 'rails71' do | ||
| gem 'rails', '~> 7.1.0' | ||
| end | ||
|
|
||
| appraise 'rails8-mysql2' do | ||
| gem 'rails', '~> 8.0.0' | ||
| gem 'mysql2', '~> 0.5', platform: :ruby | ||
| gem 'lograge', '~> 0.11' | ||
| gem 'net-smtp' | ||
| end | ||
|
|
||
| appraise 'rails8-postgres' do | ||
| gem 'rails', '~> 8.0.0' | ||
| gem 'pg', '>= 1.1', platform: :ruby | ||
| gem 'lograge', '~> 0.11' | ||
| gem 'net-smtp' | ||
| end | ||
|
|
||
| appraise 'rails8-postgres-redis' do | ||
| gem 'rails', '~> 8.0.0' | ||
| gem 'pg', '>= 1.1', platform: :ruby | ||
| gem 'redis', '~> 4' | ||
| gem 'lograge', '~> 0.11' | ||
| gem 'net-smtp' | ||
| end | ||
|
|
||
| appraise 'rails8-postgres-sidekiq' do | ||
| gem 'rails', '~> 8.0.0' | ||
| gem 'pg', '>= 1.1', platform: :ruby | ||
| gem 'sidekiq', '~> 8' | ||
| gem 'lograge', '~> 0.11' | ||
| gem 'rails_semantic_logger', '~> 4.0' | ||
| gem 'net-smtp' | ||
| end | ||
|
|
||
| appraise 'rails8-semantic-logger' do | ||
| gem 'rails', '~> 8.0.0' | ||
| gem 'pg', '>= 1.1', platform: :ruby | ||
| gem 'rails_semantic_logger', '~> 4.0' | ||
| gem 'net-smtp' | ||
| end | ||
|
|
||
| appraise 'rails8-trilogy' do | ||
| gem 'rails', '~> 8.0.0' | ||
| gem 'trilogy' | ||
| gem 'sprockets', '< 4' | ||
| gem 'lograge', '~> 0.11' | ||
| gem 'net-smtp' | ||
| end | ||
|
|
||
| appraise 'rails-old-redis' do | ||
| # All dependencies except Redis < 4 are not important, they are just required to run Rails tests. | ||
| gem 'redis', '< 4' | ||
| gem 'rails', '~> 6.1.0' | ||
| gem 'pg', '>= 1.1', platform: :ruby | ||
| gem 'sprockets', '< 4' | ||
| gem 'lograge', '~> 0.11' | ||
| end | ||
|
|
||
| appraise 'resque2-redis3' do | ||
| gem 'redis', '< 4.0' | ||
| gem 'resque', '>= 2.0' | ||
| end | ||
|
|
||
| appraise 'resque2-redis4' do | ||
| gem 'redis', '>= 4.0' | ||
| gem 'resque', '>= 2.0' | ||
| end | ||
|
|
||
| appraise 'aws' do | ||
| gem 'aws-sdk' | ||
| gem 'shoryuken' | ||
| gem 'ostruct' | ||
| end | ||
|
|
||
| appraise 'http' do | ||
| gem 'ethon' | ||
| gem 'http' | ||
| gem 'httpclient' | ||
| gem 'typhoeus' | ||
| end | ||
|
|
||
| build_coverage_matrix('stripe', 7..12, min: '5.15.0') | ||
| build_coverage_matrix('opensearch', [2], gem: 'opensearch-ruby') | ||
| build_coverage_matrix('elasticsearch', [7]) | ||
| build_coverage_matrix('faraday') | ||
| build_coverage_matrix('excon') | ||
| build_coverage_matrix('rest-client') | ||
| build_coverage_matrix('mongo', min: '2.20.0') | ||
| build_coverage_matrix('dalli', [2]) | ||
| build_coverage_matrix('karafka', min: '2.3.0') | ||
| build_coverage_matrix('devise', min: '3.2.1') | ||
|
|
||
| appraise 'relational_db' do | ||
| # ActiveRecord locked because tests are failing with 7.1, which was attempted as a part of Ruby 3.4 testing in CI. | ||
| # All existing relational_db configurations use ActiveRecord 7.0. ActiveRecord 7.1 is tested as a part of rails71 | ||
| # appraisal configurations. The latest version of sqlite3 (i.e. 2+) requires ActiveRecord 7.1, so sqlite3 version | ||
| # has been locked as well. | ||
| # | ||
| # TODO: Repair the failures with ActiveRecord 7.1 in this configuration and remove the locked version. | ||
| # TODO: After ActiveRecord is upgraded to 7.1+, sqlite3 can be unlocked as well. | ||
| gem 'activerecord', '~> 7.0.0' | ||
| gem 'delayed_job' | ||
| gem 'delayed_job_active_record' | ||
| gem 'makara', '>= 0.6.0.pre' # Ruby 3 requires >= 0.6.0, which is currently in pre-release: https://rubygems.org/gems/makara/versions | ||
| gem 'mysql2', '>= 0.5.3', platform: :ruby | ||
| gem 'pg', platform: :ruby | ||
| gem 'sqlite3', '~> 1.4', platform: :ruby | ||
| gem 'sequel' | ||
| gem 'trilogy' | ||
| end | ||
|
|
||
| appraise 'activesupport' do | ||
| gem 'activesupport', '~> 7' | ||
| gem 'actionpack' | ||
| gem 'actionview' | ||
| gem 'active_model_serializers', '>= 0.10.0' | ||
| gem 'grape' | ||
| gem 'lograge' | ||
| gem 'racecar', '>= 0.3.5' | ||
| gem 'ruby-kafka', '>= 0.7.10' | ||
| end | ||
|
|
||
| appraise 'contrib' do | ||
| gem 'concurrent-ruby' | ||
| gem 'rack-test' # Dev dependencies for testing rack-based code | ||
| gem 'rake', '>= 12.3' | ||
| gem 'resque' | ||
| gem 'roda', '>= 2.0.0' | ||
| gem 'semantic_logger', '~> 4.0' | ||
| # Note: Sidekiq 8 uses different timestamp formatting compared to prior versions. As long as | ||
| # versions <8 are supported, make sure there's some CI running both older and newer versions. | ||
| gem 'sidekiq', '~> 8' | ||
| gem 'sneakers', '>= 2.12.0' | ||
| gem 'sucker_punch' | ||
| gem 'que', '>= 1.0.0' | ||
|
|
||
| # When Rack 3+ is used, we need rackup. | ||
| gem 'rackup' | ||
| end | ||
|
|
||
| [ | ||
| '2.3', | ||
| '2.2', | ||
| '2.1', | ||
| '2.0', | ||
| '1.13', | ||
| ].each do |v| | ||
| appraise "graphql-#{v}" do | ||
| gem 'rails', '~> 6.1.0' | ||
| gem 'graphql', "~> #{v}.0" | ||
| gem 'sprockets', '< 4' | ||
| gem 'lograge', '~> 0.11' | ||
| gem 'mutex_m', '>= 0.1.0' | ||
| end | ||
| end | ||
|
|
||
| build_coverage_matrix('redis', [3, 4]) | ||
| build_coverage_matrix('rack', [2], meta: { 'rack-contrib' => nil, 'rack-test' => nil }) | ||
|
|
||
| [2, 3, 4].each do |n| | ||
| appraise "sinatra-#{n}" do | ||
| gem 'sinatra', "~> #{n}" | ||
| gem 'sinatra-contrib', "~> #{n}" | ||
| gem 'rack-contrib' | ||
| gem 'rack-test' # Dev dependencies for testing rack-based code | ||
| end | ||
| end | ||
|
|
||
| appraise 'opentelemetry' do | ||
| gem 'opentelemetry-sdk', '~> 1.1' | ||
| end | ||
|
|
||
| appraise 'opentelemetry_otlp' do | ||
| gem 'opentelemetry-api', '< 1.5' # Context is kept in `Thread.current#[]` | ||
| gem 'opentelemetry-sdk', '~> 1.1' | ||
| gem 'opentelemetry-exporter-otlp' | ||
| end | ||
|
|
||
| appraise 'opentelemetry_otlp_1_5' do | ||
| gem 'opentelemetry-api', '>= 1.5' # Context is kept as instance variable in `Fiber.current` | ||
| gem 'opentelemetry-sdk', '~> 1.1' | ||
| gem 'opentelemetry-exporter-otlp' | ||
| end | ||
|
|
||
| appraise 'contrib-old' do | ||
| gem 'presto-client', '>= 0.5.14' # Renamed to trino-client in >= 1.0 | ||
| end | ||
|
|
||
| appraise 'core-old' do | ||
| gem 'dogstatsd-ruby', '~> 4' | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.