Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Oct 2, 2025

What does this PR do?
This PR changes rake test:appsec:integration so that the task runs each test file as a separate process.

Motivation:
Rails has a lot of global state, which is quite hard to reset between tests that create different minimal Rails applications.

Change log entry
None. This change is internal.

Additional Notes:
None.

How to test the change?
CI

    request_headers_collection_for_identity_spec.rb
@y9v y9v self-assigned this Oct 2, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Oct 2, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

Rails Log Auto Injection with log injection enabled with Tagged Logging with Tagged logging setup and no tags injects trace_id into logs from rspec (Datadog) (✨ Fix with BitsAI)
server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.

Failure/Error: initialize!

PG::UnableToSend:
  server closed the connection unexpectedly
  	This probably means the server terminated abnormally
  	before or while processing the request.
...

ℹ️ Info

🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 101.99% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 05380dc | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2025

Benchmarks

Benchmark execution time: 2025-10-02 12:36:45

Comparing candidate commit 05380dc in PR branch isolate-appsec-integration-tests with baseline commit 4ab26d0 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - Allocations ()

  • 🟩 throughput [+192197.257op/s; +200079.555op/s] or [+6.091%; +6.341%]

@y9v
Copy link
Member Author

y9v commented Oct 6, 2025

Closing this, since we have a ticket to work on that

@y9v y9v closed this Oct 6, 2025
@y9v y9v deleted the isolate-appsec-integration-tests branch October 6, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants