Enable Endpoint Collection feature by default #4931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endpoint_collection_spec.rb
branch 'appsec-enable-endpoint-collection-by-default' on '4ab26d0b58'.
endpoint_collection_spec.rb
github-actions
bot
added
integrations
endpoint_collection_spec.rb
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 8f44c50 | Docs | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-10-02 16:09:06 Comparing candidate commit df5562b in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:profiling - Allocations ()
scenario:tracing - Propagation - Trace Context
|
p-datadog
reviewed
Oct 2, 2025
spec/datadog/appsec/integration/contrib/rails/endpoint_collection_spec.rb
Outdated
Show resolved
Hide resolved
Member
|
The title of this PR doesn't match the first statement in the description though the PR contains both changes - should the title reflect the feature being enabled by default? |
y9v
changed the title
Member
Author
|
@p-datadog thanks, good catch! The PR was actually auto-generated from my commit title, and I forgot to change it. |
endpoint_collection_spec.rb
Strech
approved these changes
Oct 7, 2025
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It enables Endpoint Collection by default for AppSec users. I also adds a safeguard that rescues exceptions during routes serialization.
Motivation:
We want this feature to be enabled by default for AppSec users.
Change log entry
None. This change is internal.
Additional Notes:
I also added a
rescueto the method for reporting routes as a safeguard - in case Rails changes some internals and route serialization will start raising errors.APPSEC-59521
How to test the change?
CI