Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Oct 6, 2025

What does this PR do?
It reverts Endoint Collection for AppSec.

Motivation:
AppSec integration tests are flaky due to global Rails and Devise state:
https://github.com/DataDog/dd-trace-rb/actions/runs/18269662529/job/52009951360

Change log entry
None. This is an internal change.

Additional Notes:
None.

How to test the change?
CI.

…ion"

This reverts commit b0fa779, reversing
changes made to 6075f63.
@y9v y9v self-assigned this Oct 6, 2025
@y9v y9v requested review from a team as code owners October 6, 2025 10:10
@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations appsec Application Security monitoring product labels Oct 6, 2025
Copy link
Member

@lloeki lloeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-datadog-prod-us1
Copy link
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 101.96% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1876f61 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 6, 2025

Benchmarks

Benchmark execution time: 2025-10-06 10:39:18

Comparing candidate commit 1876f61 in PR branch revert-endpoint-collection with baseline commit eae7fc6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@y9v y9v merged commit 49a5c68 into master Oct 6, 2025
357 checks passed
@y9v y9v deleted the revert-endpoint-collection branch October 6, 2025 11:27
@github-actions github-actions bot added this to the 2.22.0 milestone Oct 6, 2025
y9v added a commit that referenced this pull request Oct 6, 2025
…ion"

This reverts commit 49a5c68, reversing
changes made to eae7fc6.
vpellan pushed a commit that referenced this pull request Oct 13, 2025
…ion"

This reverts commit 49a5c68, reversing
changes made to eae7fc6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants