Skip to content

Conversation

@p-datadog
Copy link
Member

@p-datadog p-datadog commented Oct 6, 2025

What does this PR do?
Changes the format of evaluation errors in the payload to match the format used by other languages (I used python for reference)

Motivation:
Implementation correctness

Change log entry
None (expression language evaluation has not yet shipped to customers)

Additional Notes:
The format in master was simple text messages I used to get expression language implementation off the ground.

How to test the change?

Tests added

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-10-06 20:38:10 UTC

@datadog-official
Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 103.03%
Total Coverage: 101.96% (-0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eb7c8c5 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 6, 2025

Benchmarks

Benchmark execution time: 2025-10-06 18:46:02

Comparing candidate commit eb7c8c5 in PR branch di-eval-errors-schema with baseline commit 7cce081 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@p-datadog p-datadog marked this pull request as ready for review October 6, 2025 20:38
@p-datadog p-datadog requested a review from a team as a code owner October 6, 2025 20:38
@p-datadog p-datadog merged commit cc8344d into master Oct 8, 2025
358 checks passed
@p-datadog p-datadog deleted the di-eval-errors-schema branch October 8, 2025 14:28
@github-actions github-actions bot added this to the 2.22.0 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants