-
Notifications
You must be signed in to change notification settings - Fork 399
[LANGPLAT-874] Fix connection pool leaking between test cases #4964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 836. Ignored filesNote: Ignored files are excluded from the next sections.
|
590e43c to
eadeaed
Compare
BenchmarksBenchmark execution time: 2025-10-09 13:03:24 Comparing candidate commit 2daf30e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 2daf30e | Docs | Was this helpful? Give us feedback! |
eadeaed to
6868418
Compare
6868418 to
2daf30e
Compare
marcotc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome catch!
What does this PR do?
In shared inlined Rails apps we potentially leaking connection pool between different test cases when executing in fork between non-fork executions
For details see: https://datadoghq.atlassian.net/browse/LANGPLAT-874
Motivation:
This is a flaky test fix.
Change log entry
None.
Additional Notes:
None.
How to test the change?
CI is good enough.