-
Notifications
You must be signed in to change notification settings - Fork 399
Add configuration for HTTP error ranges #4991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Typing analysisNote: Ignored files are excluded from the next sections. Untyped methodsThis PR clears 2 untyped methods. It increases the percentage of typed methods from 51.1% to 51.26% (+0.16%). Untyped methods (+0-2)✅ Cleared:Untyped other declarationsThis PR clears 1 untyped other declaration. It increases the percentage of typed other declarations from 65.65% to 65.75% (+0.1%). Untyped other declarations (+0-1)✅ Cleared: |
BenchmarksBenchmark execution time: 2025-10-22 10:14:08 Comparing candidate commit 2652dce in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics. scenario:profiling - Allocations ()
scenario:profiling - stack collector (ruby frames - native filenames enabled)
scenario:tracing - Propagation - Trace Context
|
…E_HTTP_CLIENT_ERROR_STATUSES
…T_ERROR_STATUSES if not set instead of using default
29136a0 to
3524640
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 2652dce | Docs | Was this helpful? Give us feedback! |
e252d94 to
e357576
Compare
lib/datadog/tracing/contrib/action_pack/action_controller/instrumentation.rb
Outdated
Show resolved
Hide resolved
…IENT_ERROR_STATUSES system-tests
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼 Well done!
e357576 to
084ca9c
Compare
What does this PR do?
This adds configurations (DD_TRACE_HTTP_CLIENT_ERROR_STATUSES and DD_TRACE_HTTP_SERVER_ERROR_STATUSES) to configure the range of accepted values for HTTP errors
Motivation:
Resolves #3068
Change log entry
Yes. Add configurations to set ranges considered as errors for HTTP server and client errors.
Additional Notes:
How to test the change?