Skip to content

Conversation

@vpellan
Copy link
Contributor

@vpellan vpellan commented Oct 20, 2025

What does this PR do?

This adds configurations (DD_TRACE_HTTP_CLIENT_ERROR_STATUSES and DD_TRACE_HTTP_SERVER_ERROR_STATUSES) to configure the range of accepted values for HTTP errors

Motivation:

Resolves #3068

Change log entry

Yes. Add configurations to set ranges considered as errors for HTTP server and client errors.

Additional Notes:

How to test the change?

@github-actions github-actions bot added core Involves Datadog core libraries tracing integrations Involves tracing integrations labels Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR clears 2 untyped methods. It increases the percentage of typed methods from 51.1% to 51.26% (+0.16%).

Untyped methods (+0-2)Cleared:
sig/datadog/tracing/contrib/status_range_matcher.rbs:7
└── def initialize: (untyped ranges) -> void
sig/datadog/tracing/contrib/status_range_matcher.rbs:9
└── def include?: (untyped status) -> untyped

Untyped other declarations

This PR clears 1 untyped other declaration. It increases the percentage of typed other declarations from 65.65% to 65.75% (+0.1%).

Untyped other declarations (+0-1)Cleared:
sig/datadog/tracing/contrib/status_range_matcher.rbs:5
└── @ranges: untyped

@pr-commenter
Copy link

pr-commenter bot commented Oct 20, 2025

Benchmarks

Benchmark execution time: 2025-10-22 10:14:08

Comparing candidate commit 2652dce in PR branch vpellan/add-configurable-http-error-range with baseline commit 65125a4 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics.

scenario:profiling - Allocations ()

  • 🟩 throughput [+606409.123op/s; +659055.877op/s] or [+23.924%; +26.002%]

scenario:profiling - stack collector (ruby frames - native filenames enabled)

  • 🟩 throughput [+183.607op/s; +185.471op/s] or [+6.022%; +6.084%]

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+3741.269op/s; +3845.785op/s] or [+11.051%; +11.359%]

@vpellan vpellan force-pushed the vpellan/add-configurable-http-error-range branch from 29136a0 to 3524640 Compare October 21, 2025 12:06
@vpellan vpellan marked this pull request as ready for review October 21, 2025 12:06
@vpellan vpellan requested review from a team as code owners October 21, 2025 12:06
@vpellan vpellan requested a review from mabdinur October 21, 2025 12:06
@datadog-official
Copy link

datadog-official bot commented Oct 21, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.56% (+0.11%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2652dce | Docs | Was this helpful? Give us feedback!

@vpellan vpellan force-pushed the vpellan/add-configurable-http-error-range branch from e252d94 to e357576 Compare October 21, 2025 15:32
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 Well done!

@vpellan vpellan force-pushed the vpellan/add-configurable-http-error-range branch from e357576 to 084ca9c Compare October 22, 2025 09:34
@vpellan vpellan merged commit 96fa034 into master Oct 22, 2025
554 of 556 checks passed
@vpellan vpellan deleted the vpellan/add-configurable-http-error-range branch October 22, 2025 11:02
@github-actions github-actions bot added this to the 2.23.0 milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore classes option for Error Tracking

4 participants