[PROF-12846] Fix profiler not categorizing its own sleep/waiting in timeline #5000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extends the timeline thread state categorization code to recognize two frames from the profiler.
Motivation:
These two frames quite commonly show up on application profiles, and so its useful for them to be correctly categorized.
Change log entry
Yes. Fix profiler not categorizing its own sleep/waiting in timeline
Additional Notes:
Getting a thread inside the
_native_sampling_loopfor testing in this case is quite awkward so I only added test coverage for the_native_idle_sampling_loopwhich is quite easy to trigger.How to test the change?
This tiny test script produced samples from both of these frames that were uncategorized:
Here's how it looked before:
and how it looks now: