Skip to content

Conversation

@knusbaum
Copy link

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Oct 29, 2025
@github-actions
Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-10-29 18:53:26 UTC

@github-actions
Copy link

Typing analysis

Note: Ignored files are excluded from the next sections.

steep:ignore comments

This PR introduces 1 steep:ignore comment, and clears 1 steep:ignore comment.

steep:ignore comments (+1-1)Introduced:
lib/datadog/core/transport/response.rb:42
Cleared:
lib/datadog/core/transport/response.rb:38

@datadog-datadog-prod-us1
Copy link
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 98.04%
Total Coverage: 98.48% (-0.09%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a1d5759 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2025

Benchmarks

Benchmark execution time: 2025-10-29 19:24:53

Comparing candidate commit a1d5759 in PR branch knusbaum/test-429 with baseline commit 21db747 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟥 throughput [-12710.464op/s; -12040.263op/s] or [-8.341%; -7.901%]

scenario:line instrumentation - untargeted

  • 🟥 throughput [-4380.775op/s; -4168.511op/s] or [-5.587%; -5.316%]

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-2970.171op/s; -2896.576op/s] or [-9.427%; -9.193%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants