Skip to content

Conversation

@ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Oct 31, 2025

What does this PR do?

This PR adds @DataDog/ruby-guild as an additional codeowner on rbs folders.

Motivation:

While looking at @vpellan's PR
#5014 it seems overkill to need reviews from across n teams for type signature changes.

I think at this point we want to encourage all rbs contributions and lower their overhead, not make it really annoying to get them into the project, so the more reviewers the better.

Change log entry

None.

Additional Notes:

N/A

How to test the change?

CODEOWNERS changes are always annoying to test; on the other hand, if anything is wrong, it's easy to revert.

…lders

**What does this PR do?**

This PR adds `@DataDog/ruby-guild` as an additional codeowner on
rbs folders.

**Motivation:**

While looking at @vpellan's PR
#5014 it seems overkill to
need reviews from across n teams for type signature changes.

I think at this point we want to encourage all rbs contributions and
lower their overhead, not make it really annoying to get them into the
project, so the more reviewers the better.

**Additional Notes:**

N/A

**How to test the change?**

CODEOWNERS changes are always annoying to test; on the other hand, if
anything is wrong, it's easy to revert.
@ivoanjo ivoanjo requested a review from a team as a code owner October 31, 2025 09:50
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Oct 31, 2025
@datadog-official
Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.55% (-0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 79526aa | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 31, 2025

Benchmarks

Benchmark execution time: 2025-10-31 10:19:38

Comparing candidate commit 79526aa in PR branch ivoanjo/no-ticket-relax-rbs-codeowners with baseline commit 0808070 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - Allocations (baseline)

  • 🟩 throughput [+458944.272op/s; +471841.494op/s] or [+9.540%; +9.808%]

@ivoanjo ivoanjo merged commit 5f8cb92 into master Oct 31, 2025
280 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/no-ticket-relax-rbs-codeowners branch October 31, 2025 13:36
@github-actions github-actions bot added this to the 2.23.0 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/github Github repository maintenance and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants