Skip to content

Conversation

@Strech
Copy link
Member

@Strech Strech commented Nov 10, 2025

What does this PR do?

Adds openfeature-sdk to the test matrix and in addition add the gem stub due to absence of the original typespecs (but purely for used parts)

Motivation:

To reduce amount of noise in original PR

Change log entry

No.

Additional Notes:

Huge thanks to @marcotc

Closes #4962

How to test the change?

Not needed.

@Strech Strech requested a review from a team as a code owner November 10, 2025 12:47
@Strech Strech changed the title Add openfeature-sdk gem to the test matrix [FFL-1318] Add openfeature-sdk gem to the test matrix Nov 10, 2025
@Strech Strech force-pushed the ffl-1318-add-openfeature-gem-into-test-matrix branch from c554f4b to f101244 Compare November 10, 2025 13:10
@pr-commenter
Copy link

pr-commenter bot commented Nov 10, 2025

Benchmarks

Benchmark execution time: 2025-11-10 14:47:55

Comparing candidate commit 391695b in PR branch ffl-1318-add-openfeature-gem-into-test-matrix with baseline commit 6eff05b in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - sample timeline=false

  • 🟥 throughput [-0.635op/s; -0.566op/s] or [-8.781%; -7.837%]

@Strech Strech force-pushed the ffl-1318-add-openfeature-gem-into-test-matrix branch from f101244 to 8153108 Compare November 10, 2025 13:31
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 10, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.54% (+0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 391695b | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@Strech Strech merged commit c560834 into master Nov 10, 2025
571 checks passed
@Strech Strech deleted the ffl-1318-add-openfeature-gem-into-test-matrix branch November 10, 2025 14:50
@github-actions github-actions bot added this to the 2.23.0 milestone Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants