Skip to content

Conversation

@ericfirth
Copy link
Contributor

@ericfirth ericfirth commented Nov 19, 2025

What does this PR do?
This changes a tag thats sent to data-pipeline-edge to calculate kafka lag w/ dsm. Currently it was using a kafka_consume tag when it should have been kafka_commit. This fixes that.

Motivation:

Found this in the logs:

{"level":"WARN","ts":"2025-11-19T18:00:05.593059+00:00","caller":"data-pipeline-edge/payload_splitter.go:83","msg":"error parsing backlog tags. Dropping point","error":"unknown backlog type kafka_consume","org_id":2,"agent_version":"7.74.0-devel+git.368.b1be6ec","agent_env":"staging","agent_host":"i-0bf54bf3193a119d2","container_tags":[],"backlog_tags":["type:kafka_consume","topic:ruby-karafka-1","partition:0"]}

Change log entry

Additional Notes:

How to test the change?

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-11-20 17:42:12 UTC

@pr-commenter
Copy link

pr-commenter bot commented Nov 19, 2025

Benchmarks

Benchmark execution time: 2025-11-20 14:01:48

Comparing candidate commit 88dbafb in PR branch eric.firth/fix-kafka-consume_and_produce_payloads with baseline commit fde6d18 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@ericfirth ericfirth force-pushed the eric.firth/fix-kafka-consume_and_produce_payloads branch from a350087 to 88dbafb Compare November 20, 2025 13:01
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 20, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.52% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a8bc780 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants