[APMAPI-1774] Fix stable config segfault during error handling #5073
+12
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpellan
changed the title
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 96fd814 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ivoanjo
requested changes
Nov 20, 2025
Member
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
Needs a couple of fixes but I think this makes sense overall!
vpellan
force-pushed
the
vpellan/fix-segfault-library-config
branch
from
eb14b37 to
2c618e4
Compare
ivoanjo
reviewed
Nov 20, 2025
BenchmarksBenchmark execution time: 2025-11-21 10:05:25 Comparing candidate commit 96fd814 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. |
vpellan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a segfault that happens when stable config returns an error. he error is free twice
Motivation:
https://github.com/DataDog/dd-trace-rb/actions/runs/19506133836/job/55832894119?pr=5062
Change log entry
Yes. Stable config: Fix potential segfault during configuration file parsing
Additional Notes:
How to test the change?