Skip to content

Conversation

@lloeki
Copy link
Member

@lloeki lloeki commented Nov 24, 2025

What does this PR do?

Disable Ruby 3.5 preview1 testing

Motivation:

Crashes with simplecov are simply too frequent.

Change log entry

None

Additional Notes:

Testing will be attempted to be reintroduced at 4.0 preview2 level.

How to test the change?

CI should not have 3.5

@lloeki lloeki requested a review from a team as a code owner November 24, 2025 12:05
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Nov 24, 2025
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@lloeki lloeki force-pushed the lloeki/disable-ruby-3-5 branch from b7038db to 877b37e Compare November 24, 2025 12:10
@lloeki lloeki force-pushed the lloeki/disable-ruby-3-5 branch from 877b37e to ddd449c Compare November 24, 2025 12:23
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 24, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 95.16% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ddd449c | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 24, 2025

Benchmarks

Benchmark execution time: 2025-11-24 12:53:34

Comparing candidate commit ddd449c in PR branch lloeki/disable-ruby-3-5 with baseline commit efaecc3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@lloeki lloeki merged commit ae94edc into master Nov 24, 2025
544 checks passed
@lloeki lloeki deleted the lloeki/disable-ruby-3-5 branch November 24, 2025 13:15
@github-actions github-actions bot added this to the 2.23.0 milestone Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/github Github repository maintenance and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants