[PROF-13115] Disable heap profiling on Ruby 4 preview due to incompatibility #5090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility **What does this PR do?** This PR disables the heap profiling feature when running on Ruby 4 as right now it can trigger the crash reported in https://bugs.ruby-lang.org/issues/21710 . **Motivation:** Until either https://bugs.ruby-lang.org/issues/21710 gets fixed or we change the heap profiler to use the new [`rb_gc_mark_weak` API](https://bugs.ruby-lang.org/issues/19783) it's not safe to enable the heap profiling feature on Ruby 4. **Additional Notes:** I'm preparing a PR with other, smaller fixes for the profiler Ruby 4 support, but I decided to split this one by itself so we could have a separate, clear, changelog entry about this change, as well as a single PR to discuss this subject. **How to test the change?** We don't yet have Ruby 4 in CI, so this can only be tested locally or by mocking the `RUBY_VERSION`.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 662eed8 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
This was referenced Nov 25, 2025
Open
ivoanjo
deleted the
ivoanjo/prof-13115-disable-heap-profiling-ruby-4-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables the heap profiling feature when running on Ruby 4 as right now it can trigger the crash reported in
https://bugs.ruby-lang.org/issues/21710 .
Motivation:
Until either https://bugs.ruby-lang.org/issues/21710 gets fixed or we change the heap profiler to use the new
rb_gc_mark_weakAPI it's not safe to enable the heap profiling feature on Ruby 4.Change log entry
Yes. Disable heap profiling on Ruby 4 preview due to incompatibility
Additional Notes:
I'm preparing a PR with other, smaller fixes for the profiler Ruby 4 support, but I decided to split this one by itself so we could have a separate, clear, changelog entry about this change, as well as a single PR to discuss this subject.
How to test the change?
We don't yet have Ruby 4 in CI, so this can only be tested locally or by mocking the
RUBY_VERSION.