-
Notifications
You must be signed in to change notification settings - Fork 1.2k
update upgrade notes for new major version #32905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update upgrade notes for new major version #32905
Conversation
Preview links (active after the
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some thoughts, but lgtm
content/en/tracing/trace_collection/automatic_instrumentation/dd_libraries/python.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/dd_libraries/python.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/dd_libraries/python.md
Outdated
Show resolved
Hide resolved
…dd_libraries/python.md Co-authored-by: Brett Langdon <[email protected]>
duncanhewett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of general points:
- We should keep the v3 upgrade guide rather than replace it because it's still relevant for customers on <v3. I think it would be best to have a separate page for each upgrade and link from the main page, similar to this Go page.
- Some tidy up is needed with the formatting and to address the vale warnings.
|
@duncanhewett I re-included the v3 notes. Do you think it's ok to create the subpage in a separate change? |
brett0000FF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmettbutler - Awesome, thank you! I went ahead and moved the content into separate files. While moving the content, I made a few edits to your content so it fits better on a standalone page. Please let me know if you have any questions. Thanks again! 🚀
What does this PR do? What is the motivation?
Public upgrade instructions for the new major version of ddtracepy, currently in the release-candidate stage: https://github.com/DataDog/dd-trace-py/releases/tag/v4.0.0rc2
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes