Skip to content

Conversation

@emmettbutler
Copy link
Contributor

@emmettbutler emmettbutler commented Nov 18, 2025

What does this PR do? What is the motivation?

Public upgrade instructions for the new major version of ddtracepy, currently in the release-candidate stage: https://github.com/DataDog/dd-trace-py/releases/tag/v4.0.0rc2

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@emmettbutler emmettbutler requested a review from a team as a code owner November 18, 2025 18:52
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some thoughts, but lgtm

@brett0000FF brett0000FF added the editorial review Waiting on a more in-depth review label Nov 18, 2025
Copy link
Contributor

@duncanhewett duncanhewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of general points:

  • We should keep the v3 upgrade guide rather than replace it because it's still relevant for customers on <v3. I think it would be best to have a separate page for each upgrade and link from the main page, similar to this Go page.
  • Some tidy up is needed with the formatting and to address the vale warnings.

@emmettbutler
Copy link
Contributor Author

@duncanhewett I re-included the v3 notes. Do you think it's ok to create the subpage in a separate change?

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmettbutler - Awesome, thank you! I went ahead and moved the content into separate files. While moving the content, I made a few edits to your content so it fits better on a standalone page. Please let me know if you have any questions. Thanks again! 🚀

@emmettbutler emmettbutler merged commit a3b3cf6 into master Nov 19, 2025
23 of 24 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/ddtracepy-4.0-upgrade-notes branch November 19, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial review Waiting on a more in-depth review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants