Remove BUNDLE_BIN
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BUNDLE_BIN` is a path that is supposed to be specific to a given bundle. As such it cannot and should not be reused. This manifests as bundle-specific path entries being hardcoded in scripts of a potentially shared `bin` folder. As a consequence the scripts can fail unless paths happen to be identical by sheer coincidence.
This forces a rebuild because 2.6 debian is outdated and misses `git`. THs also makes local and CI build consistent.
This makes it consistent with rake
lloeki
force-pushed
the
lloeki/remove-bundle-bin
branch
from
9113761 to
8af99a8
Compare
TonyCTHsu
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUNDLE_BINis a path that is supposed to be specific to a given bundle. As such it cannot and should not be reused.This manifests as bundle-specific path entries being hardcoded in scripts of a potentially shared
binfolder. As a consequence the scripts can fail unless paths happen to be identical by sheer coincidence.A number of additional fixes and improvements were made along the way:
.repro_run_keyfile andREPRO_RUN_KEYbuild arg to control image consistency/external dependency closure via cache/layer cache usageSOURCE_DATE_EPOCHis also enabled in CI (pinned to 1980 until everything can be reliably captured or inferred from the commit, after which commit will be used), same as for rake