Skip to content

Conversation

@marcotc
Copy link
Member

@marcotc marcotc commented Mar 18, 2025

Enables the parametric test tests/parametric/test_span_events.py to run, since a new version of the agent with new span events serialization was released.

This first PR makes adjustments to the tests to adhere to the latest RFC status and it passes when running the Ruby test with the changes in this tracer PR (release version for this change still unknown).

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@marcotc marcotc force-pushed the parametric-span-events branch 3 times, most recently from 2ebc3aa to b6d1609 Compare March 19, 2025 00:31
@marcotc marcotc force-pushed the parametric-span-events branch from b6d1609 to 81761c2 Compare March 19, 2025 00:31
@marcotc marcotc marked this pull request as ready for review March 19, 2025 00:34
@marcotc marcotc requested review from a team and mabdinur as code owners March 19, 2025 00:34
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@marcotc marcotc requested a review from cbeauchesne March 21, 2025 20:46
@marcotc marcotc enabled auto-merge (squash) March 21, 2025 21:58
@marcotc marcotc merged commit e40a944 into main Mar 22, 2025
467 checks passed
@marcotc marcotc deleted the parametric-span-events branch March 22, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants