Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Oct 8, 2025

Motivation

Endpoint discovery feature is merged into dd-trace-rb again (it was reverted due to a flaky test):
DataDog/dd-trace-rb#4948

Changes

Endpoint Discovery tests are enabled for v2.22.0.dev and above.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v self-assigned this Oct 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

CODEOWNERS have been resolved as:

manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby

@y9v y9v marked this pull request as ready for review October 8, 2025 15:32
@y9v y9v requested review from a team as code owners October 8, 2025 15:32
@y9v y9v merged commit 8858105 into main Oct 9, 2025
70 checks passed
@y9v y9v deleted the ruby-enable-endpoint-discovery branch October 9, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants