Skip to content

Conversation

@jpbempel
Copy link
Member

@jpbempel jpbempel commented Oct 30, 2025

Motivation

Code Origin will be default on and therefore new spans in exception replay scenario.
To avoid updating all expected jsons, we are disabling explicitly CO for those scenarios

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

CODEOWNERS have been resolved as:

utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core

@jpbempel jpbempel marked this pull request as ready for review October 30, 2025 19:33
@jpbempel jpbempel requested review from a team as code owners October 30, 2025 19:33
@jpbempel jpbempel marked this pull request as draft October 30, 2025 19:35
@jpbempel jpbempel changed the title update snapshot for code origin default on Disable explicitly Code Origin for Exception Replay scenarios Oct 30, 2025
@jpbempel jpbempel marked this pull request as ready for review October 30, 2025 22:07
@jpbempel jpbempel merged commit b1ffcef into main Oct 31, 2025
2005 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-code-origin-default-on branch October 31, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants