Skip to content

Add weblogs and manifest configuration for FFE evaluation system tests #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 27, 2025
Merged

Add weblogs and manifest configuration for FFE evaluation system tests #5630

merged 4 commits into from
Nov 27, 2025

Conversation

@manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Oct 30, 2025 •
edited
Loading

Motivation

Add support to feature flagging evaluations to the Java weblogs

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

utils/build/docker/java/parametric/src/main/java/com/datadoghq/trace/controller/FeatureFlagEvaluatorController.java  @DataDog/apm-java @DataDog/asm-java @DataDog/system-tests-core
utils/build/docker/java/spring-boot/src/main/java/com/datadoghq/system_tests/springboot/featureflag/FeatureFlagEvaluatorController.java  @DataDog/apm-java @DataDog/asm-java @DataDog/system-tests-core
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
utils/build/docker/java/install_ddtrace.sh                              @DataDog/apm-java @DataDog/asm-java @DataDog/system-tests-core
utils/build/docker/java/parametric/install_ddtrace.sh                   @DataDog/apm-java @DataDog/asm-java @DataDog/system-tests-core
utils/build/docker/java/parametric/pom.xml                              @DataDog/apm-java @DataDog/asm-java @DataDog/system-tests-core
utils/build/docker/java/spring-boot/pom.xml                             @DataDog/apm-java @DataDog/asm-java @DataDog/system-tests-core

@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review November 24, 2025 09:35
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title [Java] Add weblogs and manifest configuration for FFE evaluation system tests Add weblogs and manifest configuration for FFE evaluation system tests Nov 24, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as draft November 24, 2025 12:15
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/ffe-evaluate-java branch 2 times, most recently from bc273f1 to 1c0596a Compare November 25, 2025 11:53
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review November 25, 2025 11:53
PerfectSlayer
PerfectSlayer approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for the Java side / left a minor comment.

@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the base branch from main to malvarez/update-java-install-scripts November 26, 2025 09:24
cbeauchesne
cbeauchesne approved these changes Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Base automatically changed from malvarez/update-java-install-scripts to main November 26, 2025 16:21
@leoromanovsky leoromanovsky mentioned this pull request Nov 26, 2025
Open
6 tasks
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 5d88781 into main Nov 27, 2025
593 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/ffe-evaluate-java branch November 27, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java

@sezen-datadog sezen-datadog Awaiting requested review from sezen-datadog sezen-datadog is a code owner automatically assigned from DataDog/asm-java

@amarziali amarziali Awaiting requested review from amarziali amarziali is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manuel-alvarez-alvarez @PerfectSlayer @cbeauchesne