Skip to content

fix: prevent version selection reset when loading more releases #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent version selection reset when loading more releases #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pupgui2/pupgui2installdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ def _threadupdate_releases_thread():
if self.loaded_page == 1:
self.ui.comboCompatToolVersion.clear()
else:
# Save the current selection before removing "Load more..."
current_index = self.ui.comboCompatToolVersion.currentIndex()
self.ui.comboCompatToolVersion.removeItem(self.ui.comboCompatToolVersion.count() - 1)

vers = self.current_ct_obj['installer'].fetch_releases(count=RELEASES_PER_PAGE, page=self.loaded_page)
Expand All @@ -102,7 +104,11 @@ def _threadupdate_releases_thread():
# Stops install dialog UI elements from being enabled when rate-limited to prevent switching/installing tools
if len(vers) > 0:
self.ui.comboCompatToolVersion.addItems(vers)
self.ui.comboCompatToolVersion.setCurrentIndex(0)
if self.loaded_page == 1:
self.ui.comboCompatToolVersion.setCurrentIndex(0)
else:
# Restore the previous selection after loading more
self.ui.comboCompatToolVersion.setCurrentIndex(current_index)

if self.more_releases_loadable:
self.ui.comboCompatToolVersion.addItem(self.tr('Load more...'))
Expand Down