Skip to content

fix: maximize window updated with resizeBounds #8427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: maximize window updated with resizeBounds #8427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/browser/provider/built-in/dedicated/chrome/cdp-client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,13 @@ export class BrowserClient {
if (client) {
const windowParams = await client.Browser.getWindowForTarget({ targetId: target.id });

await client.Emulation.clearDeviceMetricsOverride();
await client.Browser.setWindowBounds({ windowId: windowParams.windowId, bounds: { windowState: 'maximized' } });
}
}

public async resizeBounds (newDimensions: Size): Promise<void> {
const { viewportSize } = this._runtimeInfo;
const { viewportSize, config } = this._runtimeInfo;

let nonClientWidth = 0;
let nonClientHeight = 0;
Expand All @@ -258,6 +259,7 @@ export class BrowserClient {
const client = await this.getActiveClient();

if (client) {
await this._setDeviceMetricsOverride(client, newDimensions.width, newDimensions.height, 1, config.mobile);
const windowParams = await client.Browser.getWindowForTarget({ targetId: target.id });

if (windowParams.bounds.windowState !== 'normal') {
Expand Down