Refactor: Unify sync/try and promise/tryPromise APIs #701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Unify
sync/tryandpromise/tryPromiseAPIsMotivation
Currently, Effect provides four separate functions for wrapping computations:
Effect.sync()andEffect.try()for synchronous operationsEffect.promise()andEffect.tryPromise()for asynchronous operationsHowever, usage patterns in the codebase reveal that:
Effect.try()is used exclusively with the{try, catch}form (no instances found using the callback-only form)Effect.tryPromise()is used exclusively with the{try, catch}form (no instances found using the callback-only form)This indicates an opportunity to simplify the API by consolidating these functions.
Proposed Changes
Unify synchronous operations into
Effect.sync():Unify asynchronous operations into
Effect.promise():Benefits
Effect.try({ try: ... })andEffect.tryPromise({ try: ... })sync/tryorpromise/tryPromisethey just reach for the operation type they needBreaking Changes
This change is designed for Effect v4 and requires migration:
Effect.try(() => ...)Effect.sync({try: () => ...})Effect.try({try, catch})Effect.sync({try, catch})Effect.tryPromise(() => ...)Effect.promise({try: () => ...})Effect.tryPromise({try, catch})Effect.promise({try, catch})Since the
{try, catch}form is universally used in practice, this consolidation aligns the API with actual usage patterns.