Skip to content

Add retry mechanism #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add retry mechanism #1068

wants to merge 3 commits into from

Conversation

@1204552371
Copy link

@1204552371 1204552371 commented Oct 8, 2023 •
edited
Loading

When the gateway proxy proxy sends a request error, there should be a retry mechanism. The same is true for forwarding including load balancing.
In this way, error 502 caused by socket hang up and connect ECONNREFUSED can be avoided.

maxAutoRetries can be configured in gateway.config.yml. The default is 1.
such as:

      - proxy:
          - action:
              serviceEndpoint: lbsmart
              maxAutoRetries: 1
              changeOrigin: true

diegobejardelaguila
diegobejardelaguila reviewed Jul 23, 2025
View reviewed changes
lib/policies/proxy/proxy.js Outdated

const retryCountMap = {};
const proxy = httpProxy.createProxyServer(Object.assign(params, proxyOptions));
// when http request suucess,clear map
Copy link

@diegobejardelaguila diegobejardelaguila Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete comments

Copy link
Author

@1204552371 1204552371 Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will delete it

lib/policies/proxy/proxy.js Outdated
if (retryCount < maxAutoRetries) {
retryCount++;
retryCountMap[requestID] = retryCount;
// console.log(`retry count: ${retryCount} `, req.originalUrl);
Copy link

@diegobejardelaguila diegobejardelaguila Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete console.logs

Copy link
Author

@1204552371 1204552371 Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will delete it

@1204552371 1204552371 requested a review from Yedfree August 10, 2025 16:09
@1204552371
Copy link
Author

1204552371 commented Aug 10, 2025

I checked and found that the test error was due to the resources in the test case being currently inaccessible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diegobejardelaguila diegobejardelaguila diegobejardelaguila left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@1204552371 @diegobejardelaguila