ospfd: Fix sign comparison warnings in SNMP code #20029
Merged
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmauch
force-pushed
the
ospf_snmp_compile_fixes
branch
from
ffed024 to
e63388a
Compare
Author
|
Possibly related: #20020 |
Member
|
Still relevant after #20020? |
Author
|
I would suggest yes as the underlying type in v->namelen isn't size_t - so a compiler will warn in the future or with -pedantic or -Wall about this mismatch, the alternative would be to change namelen in trap_object to be size_t but that code uses -1 to mean undefined |
Member
|
Please drop merge commits. |
Fix compiler warnings about comparing signed and unsigned integers by casting arithmetic expressions to size_t to match the type of *length parameter. Fixed in functions: - ospfAreaRangeLookup - ospfHostLookup - ospfIfLookup - ospfIfMetricLookup - ospfVirtIfLookup - ospfNbrLookup - ospfExtLsdbLookup Signed-off-by: jared mauch <[email protected]>
jaredmauch
force-pushed
the
ospf_snmp_compile_fixes
branch
from
7fea652 to
bc1836d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compiler warnings about comparing signed and unsigned integers by casting arithmetic expressions to size_t to match the type of *length parameter.
Fixed in functions: